-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update numpy requirement from 1.26.4 to 2.0.0 #656
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #656 +/- ##
======================================
Coverage 97.7% 97.7%
======================================
Files 166 166
Lines 3247 3247
Branches 795 795
======================================
Hits 3174 3174
Misses 48 48
Partials 25 25 ☔ View full report in Codecov by Sentry. |
3acde1f
to
a26db37
Compare
@dependabot rebase |
a26db37
to
39cddac
Compare
The doc examples in this PR are still failing because the expected output is |
The failures are due to newer print options in numpy. So, it's understandable they don't appear as failures in pytest workflows as we don't use https://numpy.org/neps/nep-0051-scalar-representation.html My suggestion is to change the expected outputs in docstring examples to be consistent with the new print options. WDYT @vprusso ? We could set the print option to use an earlier version of numpy. But this does not make sense as a user will see the newer scalar representations pop up if they print something locally. |
This PR is very close. The only failure that we have to deal with is below:
https://github.com/vprusso/toqito/actions/runs/9933035887/job/27435221058#step:5:3171 I think it's better to disable this for now and create a separate issue for the error. It will take me a while to dig into the source of the raised error. |
51a6b1d
to
b475b60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I agree with your comment about the symmetric_extension_hierarchy
function and saw that you raised another issue to capture that. Modulo that though, glad to have numpy==2.0
supported! Nice work!
|
||
Calculate the purity of the Werner state: | ||
|
||
>>> from toqito.states import werner | ||
>>> rho = werner(2, 1 / 4) | ||
>>> '%.4f' % purity(rho) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, I missed this one from before!
Looks great, @purva-thakre. Once the merge conflict with the |
@dependabot rebase |
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
fd4e297
to
0c1a1ef
Compare
Updates the requirements on [numpy](https://github.com/numpy/numpy) to permit the latest version. - [Release notes](https://github.com/numpy/numpy/releases) - [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst) - [Commits](numpy/numpy@v1.26.4...v2.0.0) --- updated-dependencies: - dependency-name: numpy dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Will check on what the installation issues mean later. https://github.com/vprusso/toqito/actions/runs/9939417469/job/27454339453?pr=656#step:4:283 |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
We are already doing what the top voted answer recommends. There are two different errors. cvxopt and pep 517 related SO links are above. The other one is Why do we see these failures for python 3.12 on ubuntu and macos only? |
Not the same error we are getting but similar pep517 messages were fixed by downgrading poetry. |
3cab80a
to
fef7844
Compare
e5a26d9
to
c414839
Compare
307e798 might have worked except that cvxopt is being installed as a dependency again through Need to create a better dependency group. |
A newer version of numpy exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
@dependabot recreate |
Superseded by #752. |
Fixes #618
Updates the requirements on numpy to permit the latest version.
Release notes
Sourced from numpy's releases.
... (truncated)
Commits
1d49c7f
Merge pull request #26698 from charris/prepare-2.0.02103511
DOC: Remove duplicate in author list.db8030e
BUG: Change cibuildwheel version [wheel build]1a68264
REL: Prepare for the NumPy 2.0.0 release [wheel build]c8665ba
Merge pull request #26696 from charris/backport-26582103f4dd
Merge pull request #26697 from charris/backport-25963c193dcd
Merge pull request #26695 from charris/backport-266678fa8191
BUG: Fix bug in numpy.pad() (#25963)ece3559
BUG: weighted nanpercentile, nanquantile and multi-dim q (#26582)b31e195
BUG: Adds asanyarray to start of linalg.cross (#26667)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)