Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo numpy upgrade #653

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Undo numpy upgrade #653

merged 1 commit into from
Jul 8, 2024

Conversation

purva-thakre
Copy link
Collaborator

@purva-thakre purva-thakre commented Jul 8, 2024

Description

Related to all the failures after #642

Changes

Notable changes that this PR has either accomplished or will accomplish. Feel free to add more lines to the itemized list
below.

  • Change 1

Checklist

Before marking your PR ready for review, make sure you checked the following locally. If this is your first PR, you might be notified of some workflow failures after a maintainer has approved the workflow jobs to be run on your PR.

Additional information is available in the documentation.

  • Use ruff for errors related to code style and formatting.
  • Verify all previous and newly added unit tests pass in pytest.
  • Check the documentation build does not lead to any failures. Sphinx build can be checked locally for any failures related to your PR
  • Use linkcheck to check for broken links in the documentation
  • Use doctest to verify the examples in the function docstrings work as expected.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.6%. Comparing base (eb7d365) to head (e043d8d).

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #653   +/-   ##
======================================
  Coverage    97.6%   97.6%           
======================================
  Files         162     162           
  Lines        3216    3216           
  Branches      789     789           
======================================
  Hits         3142    3142           
  Misses         48      48           
  Partials       26      26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@purva-thakre purva-thakre marked this pull request as ready for review July 8, 2024 01:58
@purva-thakre purva-thakre requested a review from vprusso July 8, 2024 01:58
@purva-thakre purva-thakre merged commit d80f59a into master Jul 8, 2024
33 of 34 checks passed
@purva-thakre purva-thakre deleted the numpy_previous_version branch July 8, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant