Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing sparse matrix for symmetric projection. #638

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

vprusso
Copy link
Owner

@vprusso vprusso commented Jun 25, 2024

Closes #537

  • Removing scipy.sparse in symmetric_projection.py
  • Small simplifications and improvements to symmetric_projection.py
  • Adding more tests in test_symmetric_projection.py.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.6%. Comparing base (c826b57) to head (6978d20).

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #638   +/-   ##
======================================
  Coverage    97.6%   97.6%           
======================================
  Files         162     162           
  Lines        3212    3216    +4     
  Branches      787     789    +2     
======================================
+ Hits         3138    3142    +4     
  Misses         48      48           
  Partials       26      26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@purva-thakre purva-thakre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for catching the invalid input scenarios.

@vprusso vprusso merged commit eb7d365 into master Jul 2, 2024
18 checks passed
@vprusso vprusso deleted the 537-symmetric-projection-lil-matrix-remove branch July 2, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove lil_matrix in toqito/perms/symmetric_projection.py
2 participants