Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert reduction to array #495

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

Bchass
Copy link
Contributor

@Bchass Bchass commented Feb 29, 2024

Description

Resolves: #470

Changes

  • Convert identity(matrix by default) to an array with to.array()

Checklist

  • Use ruff and pylint for errors related to code style and formatting.
  • Verify all previous and newly added unit tests pass in pytest.
  • Check the documentation build does not lead to any failures. Sphinx build can be checked locally for any failures related to your PR
  • Use linkcheck to check for broken links in the documentation
  • Use doctest to verify the examples in the function docstrings work as expected.

@Bchass Bchass changed the title Convert to array Convert reduction to array Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.1%. Comparing base (c44a3c7) to head (8a057cf).

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #495   +/-   ##
======================================
  Coverage    98.1%   98.1%           
======================================
  Files         161     161           
  Lines        3095    3096    +1     
  Branches      752     752           
======================================
+ Hits         3037    3038    +1     
  Misses         37      37           
  Partials       21      21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@vprusso vprusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@purva-thakre purva-thakre merged commit 2b52638 into vprusso:master Mar 1, 2024
18 checks passed
@Bchass Bchass deleted the reduction_array branch March 1, 2024 14:22
@purva-thakre purva-thakre added this to the v1.0.8 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output of toqito/channels/reduction.py is a 2D list
3 participants