Use channel_dim.
#161
Merged
Use channel_dim.
#161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are places where we failed to retrieve the input and output dimensions of a general channel. This commit uses the recently added function `channel_dim` and fixes: 1. `kraus_to_choi` if non square input. Additionally flat list for CPTP channels are now supported. 2. `is_unital` if unequal input and output dims. 3. `dual_channel` if non square input and output.
|
You strike again, @georgios-ts . This is such a great change. Thank you for tackling this one! |
vprusso
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are places where we failed to retrieve the input and output dimensions of a general channel. This commit uses the recently added function
channel_dimand fixes:kraus_to_choiif non square input. Additionally flat list for CPTP channels are now supported (related to Enhancement: Functionschoi_to_krausandkraus_to_choishould take either 1D or 2D input for Kraus ops #79).is_unitalif unequal input and output dims.dual_channelif non square input and output.Status