-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial VBscript to JS transpiling support #32
Conversation
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
========================================
+ Coverage 90.3% 90.3% +0.1%
========================================
Files 136 139 +3
Lines 8595 8641 +46
Branches 988 991 +3
========================================
+ Hits 7756 7800 +44
- Misses 509 511 +2
Partials 330 330
Continue to review full report at Codecov.
|
Yay! :) I've made some progress on the API side, Kicker, Plunger, Primitive and Surface APIs are implemented and should be functional. If you have a minute to rebase this against master (the physics changes are merged) that would be great, otherwise I'll do it later. Thanks a lot, this is awesome! |
fcf2697
to
d3cb109
Compare
…d declarations with string assignments
…. Added initial support for SubCall statements.
d3cb109
to
1c5a2d4
Compare
I refactored quite a lot (don't worry, your code was still immensely helpful!). There is going to be a lot of post-processing code, so I started by splitting it into two files:
One note: Try to avoid putting rules in the grammar that aren't used. I commented some out, but typically I would assume everything that is in there is currently in use (aka unit-tested). I think we have a good base now. I'll let you go through it and if you're happy I'll merge! |
All the changes are fine. I like it! Agree with rules that aren't used, sorry about that! |
Merged, thanks! For me the next thing would be function definitions. For example: Sub BallDrain_Hit()
BallRelease.CreateBall
BallRelease.Kick 0, -1
End Sub would become: function BallDrain_Hit() {
BallRelease.CreateBall();
BallRelease.Kick(0, -1);
} This would allow me to start implementing the event handling that is going on. |
This PR adds initial support for transpiling VBScript into Javascript.
Currently the grammar can handle: