Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Inline If and Logical Expressions #115

Merged
merged 1 commit into from
Oct 26, 2019
Merged

Support Inline If and Logical Expressions #115

merged 1 commit into from
Oct 26, 2019

Conversation

jsm174
Copy link
Contributor

@jsm174 jsm174 commented Oct 26, 2019

Add support for inline if statements to fix #114.

Also convert Or and And to use Logical Expressions (||, and &&). This is in reference to #111.

There may be a follow-up PR if we find scripts the use Or and And as Binary Expressions.

@codecov
Copy link

codecov bot commented Oct 26, 2019

Codecov Report

Merging #115 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #115     +/-   ##
========================================
+ Coverage    91.3%   91.4%   +0.1%     
========================================
  Files         244     244             
  Lines       13184   13185      +1     
  Branches     1511    1510      -1     
========================================
+ Hits        12034   12041      +7     
+ Misses        684     679      -5     
+ Partials      466     465      -1
Impacted Files Coverage Δ
lib/scripting/post-process/expr.ts 97.7% <100%> (ø) ⬆️
lib/scripting/post-process/if.ts 100% <100%> (ø) ⬆️
lib/scripting/estree.ts 86.7% <100%> (+0.5%) ⬆️
lib/vpt/flipper/flipper-hit.ts 82.7% <0%> (+0.3%) ⬆️
lib/vpt/ball/ball-hit.ts 77.5% <0%> (+0.9%) ⬆️
lib/physics/hit-line-z.ts 88.9% <0%> (+4.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9311bae...4edfe35. Read the comment docs.

@freezy
Copy link
Member

freezy commented Oct 26, 2019

Awesome, thank you!

@freezy freezy merged commit 7812ce9 into master Oct 26, 2019
@jsm174 jsm174 deleted the inline-if-fix branch January 10, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline If Statement parse failure
2 participants