Skip EOL operating systems in GHA acceptance tests #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
commented
May 7, 2024
ekohl
force-pushed
the
skip-eol-os
branch
3 times, most recently
from
2c9b529
to
ea1bf54
Compare
bastelfreak
approved these changes
May 7, 2024
bastelfreak
approved these changes
May 7, 2024
ekohl
commented
May 7, 2024
| message = "Skipping EOL operating system #{os} #{release}" | ||
|
|
||
| if ENV.key?('GITHUB_ACTIONS') | ||
| # TODO: determine file and position within the file |
There was a problem hiding this comment.
The metadata instance doesn't have the original file location and only the parsed content, so it can't point to exactly where it was. In practice we pretty much only support metadata.json so this is close enough now.
bastelfreak
reviewed
May 7, 2024
bastelfreak
approved these changes
May 7, 2024
Merged
With CentOS Linux 7 and CentOS Stream 8 going EOL soon, these will start to fail because mirrors will no longer be available. This creates an annotation and skips the OS release. It introduces parameters to pretend it's a different date to keep the test suite consistent and avoid breaking it automatically over time.
bastelfreak
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With CentOS Linux 7 and CentOS Stream 8 going EOL soon, these will start to fail because mirrors will no longer be available. This creates an annotation and skips the OS release.