move params to data-in-modules #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juniorsysadmin
approved these changes
Mar 3, 2018
ekohl
requested changes
Mar 3, 2018
| systemd::networkd_ensure: 'running' | ||
| systemd::manage_timesyncd: false | ||
| systemd::timesyncd_ensure: 'running' | ||
| systemd::ntp_server: ~ |
There was a problem hiding this comment.
I'm not sure what the best practice is, but I think it's cleaner to have any Optional type in init.pp default to undef.
There was a problem hiding this comment.
AFAIK best practice is ~, which is also used in the puppetlabs modules.
There was a problem hiding this comment.
I guess it would be more consistent to have all parameters in hiera.
|
LGTM, but I think there should be a warning in the README that you need to use the Hiera 5 format to use the module from then on. |
bastelfreak
force-pushed
the
datainmodules
branch
from
6ab5b22
to
4b1e52d
Compare
op-ct
pushed a commit
to op-ct/puppet-systemd
that referenced
this pull request
Jun 17, 2022
Emtpy hiera files throw puppet 4 warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got pulled out of #65. The lowest recommended puppet version for this is 4.10.10. In the Vox Pupuli namespace we had a lot of argumentation if this requires a major version bump or not. From a point of defensive programming this should be a major bump.