Add support for drop-in files #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The drop-in directory must not created more then once, even if multiple drop-in files per unit are created. Also drop-in files for units, which are not deployed via puppet, should be supported. The only solution is to use ensure_resource from puppetlabs/stdlib. Everything else is the same as for a unit_file, except the name of the drop-in file, which has to end with '.conf'.
raphink
requested changes
Aug 16, 2017
README.md
Outdated
| @@ -36,6 +36,39 @@ file { '/usr/lib/systemd/system/foo.service': | |||
| ~> Class['systemd::systemctl::daemon_reload'] | |||
| ``` | |||
|
|
|||
| ### drop-in files | |||
|
|
|||
| Drop-in files are used to add or alter settings of a unit without modify the | |||
README.md
Outdated
| ### drop-in files | ||
|
|
||
| Drop-in files are used to add or alter settings of a unit without modify the | ||
| unit it self. As for the unit files, the module can handle the file and |
|
@raphink Fixed the noted typos. |
ekohl
reviewed
Aug 16, 2017
| @@ -0,0 +1 @@ | |||
| type Systemd::Dropin = Pattern['^.+\.conf$'] | |||
There was a problem hiding this comment.
I wonder if it should check if there's no slashes in there.
There was a problem hiding this comment.
I can add a check if there is no slash in there. I tried to use the same kind of pattern definition as for Systemd::Unit and there isn't a check for slashes.
raphink
approved these changes
Aug 17, 2017
Closed
op-ct
pushed a commit
to op-ct/puppet-systemd
that referenced
this pull request
Jun 17, 2022
Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This solves #15. I know, there is another pull request, which manage drop-in files. But my solution is able to mange multiple drop-in files, even when the service file isn't managed by the
::systemdmodule. I've also updated the spec tests and the README.Regards