Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General cleanup + add Puppet4 datatypes #32

Merged
merged 8 commits into from
Jul 19, 2017

Conversation

bastelfreak
Copy link
Member

No description provided.

@ekohl
Copy link
Member

ekohl commented Jul 13, 2017

How does this relate to #18?

@bastelfreak
Copy link
Member Author

bastelfreak commented Jul 13, 2017

Shiiiiit I missed #18 :(
We should probably integrate both. I'm fine with dropping my puppet4 commit here.

bastelfreak referenced this pull request Jul 14, 2017
* purge trailing whitespace

* add management for systemd-resolved
bastelfreak referenced this pull request Jul 14, 2017
* add systemd::network defined resource

* manage systemd-networkd in init.pp
Copy link

@EmilienM EmilienM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

@EmilienM
Copy link

it would be really great to merge that PR, one day.

@mmerfort
Copy link
Member

A forge release after this has been merged would also be great.

@trevor-vaughan
Copy link
Contributor

@bastelfreak #18 has been merged if you want to rebase and/or see if you have anything that needs to be changed that should be in this PR.

@raphink raphink merged commit 89b8c4a into voxpupuli:master Jul 19, 2017
@bastelfreak bastelfreak deleted the improvements branch July 19, 2017 19:30
openstack-gerrit pushed a commit to openstack/openstack that referenced this pull request Jul 24, 2017
Project: openstack/tripleo-heat-templates  99dd25fb23a5e0dd153561a11f91793fed4a3a65

Revert "Disable systemd-networkd & systemd-resolved"

voxpupuli/puppet-systemd#32 is disabling by default the services so we don't have to control them via TripleO.

This reverts commit d24874c7b2625e25630534a86864a93050f661d3.

Change-Id: I4044f0b28b636c7a022912f6f24707bce22c8b98
Related-Bug: #1704160
openstack-gerrit pushed a commit to openstack-archive/tripleo-heat-templates that referenced this pull request Jul 24, 2017
voxpupuli/puppet-systemd#32 is disabling by default the services so we don't have to control them via TripleO.

This reverts commit d24874c.

Change-Id: I4044f0b28b636c7a022912f6f24707bce22c8b98
Related-Bug: #1704160
@raphink raphink added the enhancement New feature or request label Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants