Add restart_service parameter on service_limits for compatibility #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 8a9e03a the parameter was removed, but this makes it very hard for modules to be compatible with both < 4 and >= 4. Requiring >= 4 will be painful, so this adds the parameter again but only accepts the parameter false. A concrete example is the puppet-redis module which sets restart_service to false to prevent a restart. This would be compatible with both the old and new behavior, making upgrades smoother. Fixes: 8a9e03a
bastelfreak
approved these changes
Jan 27, 2023
Merged
jhoblitt
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 8a9e03a the parameter was removed, but this makes it very hard for modules to be compatible with both < 4 and >= 4. Requiring >= 4 will be painful, so this adds the parameter again but only accepts the parameter false.
A concrete example is the puppet-redis module which sets restart_service to false to prevent a restart. This would be compatible with both the old and new behavior, making upgrades smoother.