feat: manage timesyncd package on Debian >= 11 and Ubuntu >= 20.04 #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Sep 28, 2022
saz
force-pushed
the
timesyncd-package
branch
from
2817c85
to
97cc910
Compare
|
@ekohl I've just pushed a change removing the repeated examples, although I'd say it's better to keep them, just to be sure. |
ekohl
approved these changes
Sep 28, 2022
saz
force-pushed
the
timesyncd-package
branch
from
97cc910
to
db33854
Compare
ekohl
approved these changes
Sep 28, 2022
Merged
|
@jhoblitt while I'm the person that added the enhancement label, I now think bug is better. Debian 10/Ubuntu 20.04 was already in metadata.json, so one could argue this PR doesn't add a new feature/support, it fixes existing code. |
bastelfreak
added
bug
|
@bastelfreak copy. Thank you. I will reroll the changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #294