Add parameter to manage default target #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
reviewed
Apr 18, 2022
kenyon
approved these changes
Apr 18, 2022
smortex
reviewed
Apr 19, 2022
jcpunk
changed the title
smortex
reviewed
Apr 19, 2022
jcpunk
changed the title
|
I've reworked it as a non-breaking change using |
kenyon
reviewed
Apr 19, 2022
root-expert
added
enhancement
|
I'd love to see this merged in... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
I was a bit surprised to discover that the default target for systemd was not already something this class managed.
Merging this should probably result in a meaningful version bump since folks who want a different target will need to set one explicitly. The default from systemd upstream is multi-user.target thus that is what I selected.