Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure systemd-networkd is available prior to notifying service #269

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

mat1010
Copy link
Contributor

@mat1010 mat1010 commented Mar 31, 2022

Pull Request (PR) description

In the current version of this module there's a dependency problem if systemd-networkd is not already installed prior the initial puppet run.

The class systemd::networkd, which includes the service resource of systemd-networkd is only included within the init.pp if the fact systemd_internal_services includes systemd-networkd.service. This is false until the package systemd-networkd has been installed. Unfortunately the class systemd::network tries to notify the service already if manage_networkd is set to true and does not check that the fact systemd_internal_services which leads to the following errror

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Could not find resource 'Service[systemd-networkd]' in parameter 'notify' (file: /etc/puppetlabs/code/modules/systemd/manifests/network.pp, line: 33) on node xxxxx

This PR adds the same fact checks to the network class.

@mat1010 mat1010 changed the title Ensure systemd-networkd is available piror notifing service Ensure systemd-networkd is available piror notifying service Mar 31, 2022
Copy link

@jhammons jhammons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me. Thanks!

@ekohl ekohl added the bug Something isn't working label Apr 4, 2022
@ekohl ekohl merged commit e81ef25 into voxpupuli:master Apr 4, 2022
@mat1010 mat1010 deleted the networkd_factcheck branch April 5, 2022 07:08
@kenyon kenyon changed the title Ensure systemd-networkd is available piror notifying service Ensure systemd-networkd is available prior to notifying service Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants