Ensure systemd-networkd is available prior to notifying service #269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
In the current version of this module there's a dependency problem if
systemd-networkd
is not already installed prior the initial puppet run.The class
systemd::networkd
, which includes theservice
resource ofsystemd-networkd
is only included within theinit.pp
if the factsystemd_internal_services
includessystemd-networkd.service
. This isfalse
until the packagesystemd-networkd
has been installed. Unfortunately the classsystemd::network
tries to notify the service already ifmanage_networkd
is set totrue
and does not check that the factsystemd_internal_services
which leads to the following errrorThis PR adds the same fact checks to the network class.