Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New parmater manage_resolv_conf for /etc/resolv.conf #256

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

traylenator
Copy link
Contributor

Pull Request (PR) description

If the parameter is true (default) then /etc/resolv.conf will
be managed when manage_resolved is true.

If the parameter is true (default) then `/etc/resolv.conf` will
be managed when `manage_resolved` is true.
@traylenator traylenator added the enhancement New feature or request label Feb 21, 2022
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this could also be a partial solution to #203.

@traylenator
Copy link
Contributor Author

I wonder if this could also be a partial solution to #203.

It's an alternate solution to document with this parameter false in addition

But

class{'systemd:
    manage_resolved => true,
    resolved_ensure => false,

would still result in a dead box which is what I was really trying to avoid really with #203.

( #203 will need rebasing after this I'm sure )

@ekohl ekohl merged commit a291dd9 into voxpupuli:master Feb 21, 2022
@ekohl
Copy link
Member

ekohl commented Feb 21, 2022

Time to do that rebase then I guess ;) And it's indeed what I was saying with "partial". A user could also have a profile module that then manages resolv.conf which would be good enough for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants