Use os.family for RedHat based Hiera data #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
approved these changes
Sep 8, 2021
smortex
approved these changes
Sep 8, 2021
op-ct
pushed a commit
to op-ct/puppet-systemd
that referenced
this pull request
Jun 17, 2022
add CentOS 8 default repos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Use the
os.familyfact for RedHat based systems since they will all have same defaults. This ensures CentOS 8 replacements like Alma Linux and Rocky Linux will work without having to add additional duplicate Hiera files. I ran into this issue with modules where I had Scientific Linux tests enabled, which is another RedHat clone.