Remove restart_service on service_limits define #193
Conversation
systemd::service_limits is a typeBreaking changes to this file WILL impact these 4 modules (exact match):Breaking changes to this file MAY impact these 2 modules (near match):This module is declared in 8 of 576 indexed public
|
|
This is a backwards incompatible change, but I can't apply the label. |
ekohl
force-pushed
the
drop-restart-service
branch
from
31790ab
to
cdc30b6
Compare
|
@ekohl looks like this just needs a rebase |
ekohl
force-pushed
the
drop-restart-service
branch
from
cdc30b6
to
ca26866
Compare
|
Rebased |
|
@ekohl do younneed this urgently or csn we keep it ooen for some time to avoid a major release for some time? |
|
No urgency. I'm fine with keeping this till the next major version. |
|
Dear @ekohl, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
ekohl
force-pushed
the
drop-restart-service
branch
from
ca26866
to
2a88e3f
Compare
ekohl
force-pushed
the
drop-restart-service
branch
from
2a88e3f
to
b8c5a87
Compare
ekohl
force-pushed
the
drop-restart-service
branch
from
b8c5a87
to
6254e04
Compare
| } | ||
|
|
||
| Systemd::Dropin_file["${name}-90-limits.conf"] ~> Exec["restart ${name} because limits"] | ||
| notify_service => true, |
There was a problem hiding this comment.
Should this be configurable?
ekohl
force-pushed
the
drop-restart-service
branch
from
6254e04
to
35e2f36
Compare
Since 97dd16f this parameter is a bad idea. It doesn't do a daemon reload and it may restart at the wrong time. In fact, I'd argue it's always been a bad idea. The recommended alternative to this is to manage the service explicitly and let Puppet handle it. There is an automatic notify that takes care of it. Fixes voxpupuli#190
ekohl
force-pushed
the
drop-restart-service
branch
from
35e2f36
to
8a9e03a
Compare
Since 97dd16f this parameter is a bad idea. It doesn't do a daemon reload and it may restart at the wrong time. In fact, I'd argue it's always been a bad idea.
The recommended alternative to this is to manage the service explicitly and let Puppet handle it. There is an automatic notify that takes care of it.
Fixes #190