Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit using arrays to make extending lists easier #164

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Permit using arrays to make extending lists easier #164

merged 1 commit into from
Oct 22, 2020

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Oct 20, 2020

For the loginctl user parameter lists, it is easier to set them as an array (that way I can append or de-dupe easily).

Psudo hiera:

systemd::logind_settings:
  KillExcludeUsers: 
  - root
systemd::logind_settings:
  KillExcludeUsers: 
  - other_user

@puppet-community-rangefinder
Copy link

systemd::logind is a class

that may have no external impact to Forge modules.

This module is declared in 7 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically only KillOnlyUsers and KillExcludeUsers can be lists, but for those this is a good improvement. I didn't find other lists that could have a different separator when reading man 5 logind.conf.

@raphink
Copy link
Member

raphink commented Oct 22, 2020

That should be fine, considering the type validates these parameters properly.

@raphink raphink merged commit a362b9a into voxpupuli:master Oct 22, 2020
@jcpunk jcpunk deleted the space-users branch October 22, 2020 14:47
@raphink raphink added the enhancement New feature or request label Jan 18, 2021
simondeziel pushed a commit to simondeziel/puppet-systemd that referenced this pull request Jun 16, 2021
simondeziel pushed a commit to simondeziel/puppet-systemd that referenced this pull request Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants