Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option for persistent logging #127

Merged
merged 9 commits into from
Feb 5, 2020
Merged

Conversation

djvl
Copy link
Contributor

@djvl djvl commented Nov 12, 2019

No description provided.

manifests/journald.pp Outdated Show resolved Hide resolved
@bastelfreak bastelfreak added the enhancement New feature or request label Nov 17, 2019
@bastelfreak bastelfreak changed the title added option for persistent logging add option for persistent logging Nov 17, 2019
@bastelfreak
Copy link
Member

thanks for the PR!

@bastelfreak bastelfreak merged commit b2ddb4c into voxpupuli:master Feb 5, 2020
@bastelfreak bastelfreak added backwards-incompatible and removed enhancement New feature or request labels Feb 24, 2020
@bastelfreak
Copy link
Member

I noticed that his is a backwards-incompatible change because it purges /var/log/journal. We should change the default from absent to directory

@bastelfreak bastelfreak mentioned this pull request Mar 9, 2020
bastelfreak added a commit to bastelfreak/puppet-systemd that referenced this pull request Mar 9, 2020
trevor-vaughan pushed a commit that referenced this pull request Mar 9, 2020
@raphink
Copy link
Member

raphink commented Aug 21, 2020

Marking as maintenance as this was undone in #146 and thus never released

simondeziel pushed a commit to simondeziel/puppet-systemd that referenced this pull request Jun 16, 2021
* added option for persistent logging

* added missing rspec test

* corrected two issues

* some more corrections on the test spec

* modifications for new syntax

* fix for more syntax errors

* removed trailing slash on file resource

* fix missing mode and owner
simondeziel pushed a commit to simondeziel/puppet-systemd that referenced this pull request Jun 16, 2021
simondeziel pushed a commit to simondeziel/puppet-systemd that referenced this pull request Jun 16, 2021
* added option for persistent logging

* added missing rspec test

* corrected two issues

* some more corrections on the test spec

* modifications for new syntax

* fix for more syntax errors

* removed trailing slash on file resource

* fix missing mode and owner
simondeziel pushed a commit to simondeziel/puppet-systemd that referenced this pull request Jun 16, 2021
op-ct pushed a commit to op-ct/puppet-systemd that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants