Refactor systemd facts #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but the tests don't pass. |
|
Bah, forgot to mock out the native call from the machine, didn't notice on my machine because it's a mac! Fixing now |
|
OK great. |
petems
force-pushed
the
add_spec_for_facts
branch
from
17bbe45
to
5bebf37
Compare
* Use `Facter::Util::Resolution.exec`, which is backwards compatible with older Facter, calls the same method in modern facter * Adds basic unit testing for facts
petems
force-pushed
the
add_spec_for_facts
branch
from
5bebf37
to
6c944c7
Compare
|
@raphink Ok to merge? 👍 |
|
Yes, thank you. |
op-ct
pushed a commit
to op-ct/puppet-systemd
that referenced
this pull request
Jun 17, 2022
Update changelog and version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Facter::Util::Resolution.exec, which is backwards compatible with older Facter, calls the same method in modern facter