systemd::network: Validate if content/source are set for file resource

voxpupuli · Jul 27, 2021 · 76f8eb6 · 76f8eb6
1 parent cf036c9
commit 76f8eb6
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/manifests/network.pp b/manifests/network.pp
@@ -19,6 +19,14 @@
     $notify = undef
   }
 
+  if $ensure == 'file' {
+    if $content =~ Undef and $source =~ Undef {
+      fail('you need to provide content or source')
+    }
+    if $content =~ NotUndef and $source =~ NotUndef {
+      fail('you can only set $content or $source')
+    }
+  }
   file { "${path}/${name}":
     ensure    => $ensure,
     content   => $content,

diff --git a/spec/defines/network_spec.rb b/spec/defines/network_spec.rb
@@ -61,6 +61,25 @@
 
           it { is_expected.to create_file("/etc/systemd/network/#{title}").that_notifies('Service[systemd-networkd]') }
         end
+        context 'without content and without source' do
+          let(:title) { 'wg0.netdev' }
+          let :params do
+            {}
+          end
+
+          it { is_expected.to compile.and_raise_error(%r{you need to set}) }
+        end
+        context 'with content and source' do
+          let(:title) { 'wg0.netdev' }
+          let :params do
+            {
+              content: 'bla',
+              source: 'foo'
+            }
+          end
+
+          it { is_expected.to compile.and_raise_error(%r{you can only set}) }
+        end
       end
     end
   end