access out-of-scope variables via the scope.lookupvar method #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've saved me the hassle of doing it myself. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The templates/redis-sentinel.conf.erb and templates/redis.conf.erb are accessing out-of-scope variables by accessing variables declared top level redis class.
In Puppet 4 and Puppet 3 with Future Parser enabled the values of these variables are blank in the resulting configuration files.
Puppet 4 and Puppet 3 with Future Parser enabled no longer supports relative namespace lookups.
https://tickets.puppetlabs.com/browse/PUP-121
You must access these variables by calling the scope.lookupvar function with the fully qualified variable name as the argument. This PR modifies the 2 templates to use the scope.lookupvar function.