Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Puppet 5 support #392

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Drop Puppet 5 support #392

merged 1 commit into from
Jul 16, 2021

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Feb 23, 2021

No description provided.

@ekohl
Copy link
Member Author

ekohl commented Feb 23, 2021

Looks like it fails on Debian distros because puppet-bolt isn't available.

@kenyon
Copy link
Member

kenyon commented Mar 1, 2021 •
edited
Loading

Looks like it fails on Debian distros because puppet-bolt isn't available.

Ah yes, you have to install https://apt.puppet.com/puppet-tools-release-$facts['os']['distro']['codename'].deb to enable the puppet-tools component of the repo, which contains puppet-bolt.

@ekohl
Copy link
Member Author

ekohl commented Mar 1, 2021

Ah, kind of weird that there's a difference between deb and RPM repos for that.

@ehelms
Copy link
Contributor

ehelms commented Mar 25, 2021

I noticed that this has a requires on herculesteam/augeasproviders_core which currently does not support Puppet 7:

https://github.com/hercules-team/augeasproviders_core/blob/master/metadata.json#L57

@bastelfreak
Copy link
Member

I pinged Raphael for a new augesproviders_core release

@bastelfreak
Copy link
Member

@ekohl can you rebase please?

@bastelfreak bastelfreak mentioned this pull request Apr 26, 2021
Merged
@ekohl ekohl marked this pull request as draft April 27, 2021 12:49
@ekohl
Copy link
Member Author

ekohl commented Apr 27, 2021

I've rebased this to a minimal version, but we haven't dropped Puppet 5 yet and given it's only metadata now (no actual code), I'd like to consider the alternative where we just add Puppet 7.

@ekohl
Copy link
Member Author

ekohl commented Apr 28, 2021

I've opened #400 to add Puppet 7 support.

@ekohl ekohl changed the title Drop Puppet 5, add Puppet 7 support Drop Puppet 5 support May 18, 2021
@ekohl
Copy link
Member Author

ekohl commented Jul 16, 2021

If #406 is merged, this should also get in.

@ekohl ekohl marked this pull request as ready for review July 16, 2021 11:07
@ekohl
Copy link
Member Author

ekohl commented Jul 16, 2021

Rebased

@ekohl ekohl merged commit 599434c into voxpupuli:master Jul 16, 2021
@ekohl ekohl deleted the drop-puppet-5-add-7 branch July 16, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ekohl @kenyon @ehelms @bastelfreak