Adding support for Redis6 config and new features #388
Conversation
| @@ -42,849 +43,1033 @@ repositories. | |||
|
|
|||
| ## Classes | |||
|
|
|||
| ### `redis` | |||
| ### <a name="redis"></a>`redis` | |||
There was a problem hiding this comment.
Could you regenerate REFERENCE.md prior to the changes in a separate commit to make reviewing easier?
There was a problem hiding this comment.
@ekohl I did the split to two commits
| @@ -679,7 +679,7 @@ class { 'redis::globals': | |||
|
|
|||
| it do | |||
| if facts[:operatingsystem] == 'Ubuntu' && facts[:operatingsystemmajrelease] == '16.04' | |||
| is_expected.not_to contain_file(config_file_orig).with_content(%r{protected-mode}) | |||
| is_expected.not_to contain_file(config_file_orig).with_content(%r{^protected-mode$}) | |||
There was a problem hiding this comment.
The regex isn't really needed. In fact, I'd say it's better not to be strict. It's expecting that protected-mode isn't present at all, regardless of where in the file it shows up.
There was a problem hiding this comment.
I would say it's better to be strict.
If we only set variables, without touching documentation inside the file, so people can use them for reference then
# protected-mode example would be shown somewhere which is caught by the previous regexp and the test fails
spec/classes/redis_spec.rb
Outdated
| 'ensure' => 'running', | ||
| 'enable' => 'true', |
There was a problem hiding this comment.
Generally it makes it easier to review if you separate out the visual changes to a separate commit.
There was a problem hiding this comment.
Removed from the scope of this changes
|
This now has a merge conflict. |
Pull Request (PR) description
This commit introduces the latest config for Redis6 and Sentinel, with new parameters. Additionally, the MemoryPolicy type is introduced with some small adjustments in the rest of the code.
As discussed previously on voxpupuli IRC this is a base commit, and depending on the review I will make changes accordingly.