enable sentinel bind usage with multi ip #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Sep 17, 2020
igalic
suggested changes
Sep 18, 2020
|
@ragingdave thanks for the PR! Can you add a unit test for this change? |
bastelfreak
approved these changes
Sep 18, 2020
igalic
reviewed
Sep 19, 2020
bastelfreak
added a commit
to bastelfreak/puppet-redis
that referenced
this pull request
Oct 8, 2020
chronological order: * voxpupuli#272 was opened * voxpupuli#365 was opened * voxpupuli#365 was merged * voxpupuli#272 was merged without a rebase * tests are broken
Closed
bastelfreak
added a commit
to bastelfreak/puppet-redis
that referenced
this pull request
Oct 10, 2020
chronological order: * voxpupuli#272 was opened * voxpupuli#365 was opened * voxpupuli#365 was merged * voxpupuli#272 was merged without a rebase * tests are broken
bastelfreak
added a commit
to bastelfreak/puppet-redis
that referenced
this pull request
Oct 10, 2020
chronological order: * voxpupuli#272 was opened * voxpupuli#365 was opened * voxpupuli#365 was merged * voxpupuli#272 was merged without a rebase * tests are broken
bastelfreak
added a commit
to bastelfreak/puppet-redis
that referenced
this pull request
Oct 10, 2020
chronological order: * voxpupuli#272 was opened * voxpupuli#365 was opened * voxpupuli#365 was merged * voxpupuli#272 was merged without a rebase * tests are broken
bastelfreak
added a commit
to bastelfreak/puppet-redis
that referenced
this pull request
Oct 10, 2020
chronological order: * voxpupuli#272 was opened * voxpupuli#365 was opened * voxpupuli#365 was merged * voxpupuli#272 was merged without a rebase * tests are broken
bastelfreak
added a commit
to bastelfreak/puppet-redis
that referenced
this pull request
Oct 10, 2020
chronological order: * voxpupuli#272 was opened * voxpupuli#365 was opened * voxpupuli#365 was merged * voxpupuli#272 was merged without a rebase * tests are broken
bastelfreak
added a commit
to bastelfreak/puppet-redis
that referenced
this pull request
Oct 10, 2020
chronological order: * voxpupuli#272 was opened * voxpupuli#365 was opened * voxpupuli#365 was merged * voxpupuli#272 was merged without a rebase * tests are broken
cegeka-jenkins
pushed a commit
to cegeka/puppet-redis
that referenced
this pull request
Feb 16, 2021
enable sentinel bind usage with multi ip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
There is currently an issue where if you use the allowed array of IP for the sentinel bind, this fails and the template becomes something completely broken as the resulting template shows:
This PR fixes that by using the same technique in the base redis usage to force it into an array and flatten it to generate a correct bind line.