Clean up preinstall handling and use modern facts #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This treats the entire Red Hat OS family equal. For apt handling the before is cleaned up since the apt::update dependency is defined within apt::source and apt::ppa while the package is handled because init.pp does preinstall before install.
runejuhl
reviewed
Nov 29, 2019
| @@ -3,41 +3,22 @@ | |||
| # @api private | |||
| class redis::preinstall { | |||
| if $redis::manage_repo { | |||
| case $::operatingsystem { | |||
| 'RedHat', 'CentOS', 'Scientific', 'OEL', 'Amazon': { | |||
| if $facts['os']['family'] == 'RedHat' { | |||
There was a problem hiding this comment.
I'd prefer that the case statement is kept, so that it can have a default clause that fails instead of silently ignoring it.
There was a problem hiding this comment.
Hmm, I'll split it up in a different PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.