Add an optional third parameter to redisget() to specify a default value #207
Conversation
ghoneycutt
force-pushed
the
redisget_default
branch
from
ebd2a73
to
ab7f5cc
Compare
|
@petems I got the acceptance tests this time :) |
|
@ghoneycutt Awesome stuff! 😄 I might ask you to rebase as I was doing some work to update the function docs to work with puppet-strings (see #208), but overall looks good |
|
No problem, I'll rebase once #208 gets merged. |
| raise(Puppet::ParseError, "redisget(): Wrong argument type given (#{key.class} for String) for arg1 (key)") if key.is_a?(String) == false | ||
| raise(Puppet::ParseError, "redisget(): Wrong argument type given (#{url.class} for String) for arg2 (url)") if url.is_a?(String) == false | ||
|
|
||
| begin |
There was a problem hiding this comment.
This logic looks a little confusing to me, could we clean this up somehow?
There was a problem hiding this comment.
Possibly something like changing k to returned_value? And is there a way to break out the nesting? Not sure if there's something better it just looks a little confusing IMO
There was a problem hiding this comment.
changed the variable name and added the exception message to the output as requested
| else | ||
| k | ||
| end | ||
| rescue |
There was a problem hiding this comment.
Is there a way to pick which error to rescue from here?
There was a problem hiding this comment.
Something like
rescue Exception => e
if default
debug "Connection to redis failed with #{e}"
default
else
raise(Puppet::Error, "Connection to redis server failed - #{e}")
end
endGives a little more detail for both the happy and sad paths
ghoneycutt
force-pushed
the
redisget_default
branch
from
ab7f5cc
to
a34ed57
Compare
|
Merged in #209 |
No description provided.