Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert function to API v4 ruby function #291

Closed
alexjfisher opened this issue Mar 9, 2019 · 0 comments
Closed

Convert function to API v4 ruby function #291

alexjfisher opened this issue Mar 9, 2019 · 0 comments
Milestone
v4.0.0

Comments

@alexjfisher
Copy link
Member

The modern ruby function api is environment isolation safe.
@alexjfisher alexjfisher added this to the v4.0.0 milestone Mar 9, 2019
alexjfisher added a commit to alexjfisher/puppet-redis that referenced this issue Mar 9, 2019
@alexjfisher
Convert redisget to redis::get API v4 function
cbb3373 
Since we'll be dropping puppet 3 support in the next release, we should
move away from using legacy functions that suffer from environment
isolation issues.

See https://puppet.com/docs/puppet/4.10/functions_legacy.html

Fixes voxpupuli#291
alexjfisher added a commit to alexjfisher/puppet-redis that referenced this issue Mar 9, 2019
@alexjfisher
Convert redisget to redis::get API v4 function
911d9ea 
Since we'll be dropping puppet 3 support in the next release, we should
move away from using legacy functions that suffer from environment
isolation issues.

See https://puppet.com/docs/puppet/4.10/functions_legacy.html

The newer function API also has built in support for validating function
arguments, declaring some parameters as optional etc.  This allows us to
remove a lot of our own code that was performing this validation before.

Fixes voxpupuli#291
@alexjfisher alexjfisher mentioned this issue Mar 9, 2019
Merged
alexjfisher added a commit to alexjfisher/puppet-redis that referenced this issue Mar 9, 2019
@alexjfisher
Convert redisget to redis::get API v4 function
fe0c5f0 
Since we'll be dropping puppet 3 support in the next release, we should
move away from using legacy functions that suffer from environment
isolation issues.

See https://puppet.com/docs/puppet/4.10/functions_legacy.html

The newer function API also has built in support for validating function
arguments, declaring some parameters as optional etc.  This allows us to
remove a lot of our own code that was performing this validation before.

Fixes voxpupuli#291
alexjfisher added a commit to alexjfisher/puppet-redis that referenced this issue Mar 11, 2019
@alexjfisher
Convert redisget to redis::get API v4 function
8b7104e 
Since we'll be dropping puppet 3 support in the next release, we should
move away from using legacy functions that suffer from environment
isolation issues.

See https://puppet.com/docs/puppet/4.10/functions_legacy.html

The newer function API also has built in support for validating function
arguments, declaring some parameters as optional etc.  This allows us to
remove a lot of our own code that was performing this validation before.

Fixes voxpupuli#291
cegeka-jenkins pushed a commit to cegeka/puppet-redis that referenced this issue Feb 16, 2021
@alexjfisher
Convert redisget to redis::get API v4 function
a6a61fb 
Since we'll be dropping puppet 3 support in the next release, we should
move away from using legacy functions that suffer from environment
isolation issues.

See https://puppet.com/docs/puppet/4.10/functions_legacy.html

The newer function API also has built in support for validating function
arguments, declaring some parameters as optional etc.  This allows us to
remove a lot of our own code that was performing this validation before.

Fixes voxpupuli#291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
1 participant
@alexjfisher