Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance acceptance tests #539

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mfaure
Copy link

@mfaure mfaure commented Oct 5, 2019

Pull Request (PR) description

Enhance acceptance tests

This Pull Request (PR) fixes the following issues

(TODO)

@mfaure mfaure changed the title WIP Enhance acceptance tests Enhance acceptance tests Oct 6, 2019
@vox-pupuli-tasks
Copy link

Dear @mfaure, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

1 similar comment
@vox-pupuli-tasks
Copy link

Dear @mfaure, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@bastelfreak
Copy link
Member

@mfaure can you please squash the commits into one?

@bastelfreak bastelfreak reopened this Apr 25, 2020
@mfaure
Copy link
Author

mfaure commented Apr 25, 2020

@bastelfreak Sure!

But I still don't know whether acceptance tests are OK or not (waiting for Travis).

Locally I get inconsistent errors (errors on PHP 5.6 on 16.04 and error on 18.04) which make me think I don't know how to properly run tests locally.

Do you want me to squash whatever the result of Travis?

@mfaure
Copy link
Author

mfaure commented Apr 25, 2020

Sorry, I've just seen Travis is OK. Squashing right now :)

@mfaure mfaure marked this pull request as ready for review April 25, 2020 12:24
@mfaure
Copy link
Author

mfaure commented Apr 25, 2020

@bastelfreak I think it is OK. Feel free to tell me if I missed something!

@bastelfreak
Copy link
Member

@mfaure the diff looks a bit strange and there is a merge conflict. can you please rebase against our latest master branch? (don't merge master into your feature branch)

@mfaure
Copy link
Author

mfaure commented Apr 25, 2020

@bastelfreak Thanks for your advice! Hope this time is the good one :)

@vox-pupuli-tasks
Copy link

Dear @mfaure, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants