[keepalive_requests] added keepalive_requests parameter in nginx.conf #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set it to default value of 100 as shown in nginx config Require this parameter as default value results in a huge number of TIME_WAIT connections with high QPS applications hitting nginx The check has been copied from the keepalive_timeout parameter
| @@ -62,6 +62,7 @@ http { | |||
| server_names_hash_max_size <%= @names_hash_max_size %>; | |||
|
|
|||
| keepalive_timeout <%= @keepalive_timeout %>; | |||
| keepalive_requests <%= @keepalive_requests %>; | |||
|
LGTM Default is indeed |
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
[keepalive_requests] added keepalive_requests parameter in nginx.conf
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set it to default value of 100 as shown in nginx config
Require this parameter as default value results in a huge number of TIME_WAIT connections with high QPS applications hitting nginx
The check has been copied from the keepalive_timeout parameter