Fix tests #822
Merged
Fix tests #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have some failing tests, and in the Puppet Style Guide it's a SHOULD, not a MUST that lines be under this length
Two reasons: 1. Newer is better! 2. Running lint < 2.0 with the current Rakefile will fail - lines longer than 80 chars will cause warnings, and Rakefile says to fail on warnings
* Moves beaker dependencies to system_tests group * pin puppetlabs_spec_helper and rspec-puppet to compatible versions, which should minimize future breakage * removed explicit dependency on rake
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.