Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test suite (Travis updates, librarian-puppet removal, better utilize puppet-lint) #377

Merged
merged 7 commits into from
Aug 22, 2014
Merged

Improve test suite (Travis updates, librarian-puppet removal, better utilize puppet-lint) #377

merged 7 commits into from
Aug 22, 2014

Conversation

3flex
Copy link
Contributor

@3flex 3flex commented Jul 17, 2014

  • Switch to installing modules from Forge with puppetlabs_spec_helper which recently introduced support. Brings things closer in line with the Puppetlabs module setup.
  • Extend the Travis build matrix
    • Add ruby 2.1.0
    • Add ruby 1.8.7 testing with both Puppet 2.7.x and Puppet 3.x (given module policy is YMMV with Ruby 1.8.7 these are allowed failures, meaning you still get the results from Travis but the overall build won't fail)
    • Enable Travis fast finish for quicker feedback on failing builds
    • Simplify Travis matrix to make it easier to understand which combinations of Puppet/Ruby are being tested.
    • Validate *.pp and *.erb so syntax errors raise an error
    • Run puppet-lint
  • Fix a couple minor issues from updating the tested module dependencies (librarian-puppet had them locked to older versions).
  • Be more aggressive with puppet-lint by failing on warnings (have fixed all outstanding warnings and disabled a few checks that cannot be enabled at this time)

Resolves #360
Fixes #400

@3flex 3flex changed the title Update Travis config and remove librarian-puppet Improve test suite (Travis updates, librarian-puppet removal, better utilize puppet-lint) Jul 18, 2014
@3flex 3flex mentioned this pull request Aug 13, 2014
Closed
Matthew Haughton and others added 7 commits August 18, 2014 22:41
switch to puppetlabs_spec_helper
2d4c9d9 
Removes librarian-puppet since puppetlabs_spec_helper
can now handle installing modules from the Forge.
Correct errors introduced by using latest apt module
5aa2f66 
Since librarian-puppet had locked to old versions of Forge modules
but puppetlabs_spec_helper is now pulling the latest version,
there's this incompatibility to take care of in the test suite.
Extend Travis test matrix
d7d63a8 
* Add ruby 2.1.0
* Add back ruby 1.8.7 as allowed failure - shows test results
  but won't mark build as failed
* Enable fast finish - quick feedback on failed builds
* Make test matrix explicit so it's easier to tell what's included
  in the matrix, instead of excluding certain combinations
@3flex
Add validate and lint tasks to travis script
bdaba9a
Disable noisy/unneeded puppet-lint checks
e80cb68 
* disable '80 characters check' - this is pretty useless and noisy
* disable 'class inherits from params class' check - is for puppet 2.6 which isn't supported
Fail on lint warnings from now on
51ef4bd 
Should improve PR quality and eliminate need for PRs to fix
any future lint issues
Fix remaining lint warnings
88d8984
@3flex
Copy link
Contributor Author

3flex commented Aug 22, 2014

@jfryman are you at all attached to librarian-puppet? Removing that and the Gemfile changes are the only things that might affect your workflow, I'm pretty sure the rest is solid.

The travis updates will be helpful for your refactoring. Please merge if it looks good.

@jfryman
Copy link
Contributor

jfryman commented Aug 22, 2014

are you at all attached to librarian-puppet?

Nope, not in the least. Probably shouldn't be on an individual module anyway... it's more of a site-specific thing.

jfryman pushed a commit that referenced this pull request Aug 22, 2014
Merge pull request #377 from 3flex/modernize-travis
a2dd6cd 
Improve test suite (Travis updates, librarian-puppet removal, better utilize puppet-lint)
@jfryman jfryman merged commit a2dd6cd into voxpupuli:master Aug 22, 2014
@3flex 3flex deleted the modernize-travis branch August 22, 2014 15:49
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this pull request Oct 23, 2017
Merge pull request voxpupuli#377 from 3flex/modernize-travis
be64ddc 
Improve test suite (Travis updates, librarian-puppet removal, better utilize puppet-lint)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

puppet lint
2 participants
@3flex @jfryman