Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy data types #1566

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Remove legacy data types #1566

merged 1 commit into from
Jun 13, 2024

Conversation

smortex
Copy link
Member

@smortex smortex commented Jul 5, 2023

This PR remove backwards-compatible data types which where bogus.

It is intended to be rebased on top of master and merged when we want to cut a new major version and people had the time to update their code to not rely on these.

These data types where kept for backwards compatibility, but are
syntaxically incorrect.

Remove them.
@TheMeier
Copy link
Contributor

TheMeier commented Jun 5, 2024

rebased

@TheMeier
Copy link
Contributor

TheMeier commented Jun 5, 2024

@smortex what is missing, or is this ready for review?

@smortex
Copy link
Member Author

smortex commented Jun 9, 2024

@smortex what is missing, or is this ready for review?

I think it is fine. I think I marked it as draft to avoid merging it too fast. but if we are ready for a new major version this is fine!

@TheMeier TheMeier marked this pull request as ready for review June 13, 2024 08:09
@TheMeier TheMeier merged commit 3f7e708 into master Jun 13, 2024
21 checks passed
@TheMeier TheMeier deleted the remove-legacy-data-types branch June 13, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants