Enable subdirectory hierarchy for client_body and proxy temp paths #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplindquist
force-pushed
the
temp_path_depth
branch
from
42cb2e6
to
52fe1a0
Compare
|
Neat! Looks good to me, but I'll defer to folks with more experience on this module. |
ekohl
reviewed
Jan 3, 2023
|
Thank you @ekohl , updated! |
bastelfreak
approved these changes
Jan 3, 2023
ekohl
approved these changes
Jan 3, 2023
|
I'd love to see this squashed down to one commit. |
Allow specification of up to three-level subdirectory hierarchy for both [client_body_temp_path](https://nginx.org/en/docs/http/ngx_http_core_module.html#client_body_temp_path) and [proxy_temp_path](https://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_temp_path) options This allows for the existing string option to specify just the path as it works now, and for an alternate type as an array with the first element as the path, and the up to 3 additional integers for each level - Updated docs - Updated tests Rubocop fix Apply suggestions from code review Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl> Rubocop suggested fix
jplindquist
force-pushed
the
temp_path_depth
branch
from
659642c
to
492f1a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Allow specification of up to three-level subdirectory hierarchy for both client_body_temp_path and proxy_temp_path options
This allows for the existing string option to specify just the path as it works now, and for an alternate type as an array with the first element as the path, and the up to 3 additional integers for each level