Fix acceptance tests on Arch and Ubuntu w/ Puppet 6 #1501
Conversation
nginx::params is a classBreaking changes to this file MAY impact these 1 modules (near match):This module is declared in 9 of 579 indexed public
|
|
Ubuntu specs will be fixed after puppetlabs/puppetlabs-apt#1017 gets merged an released. Although we need to explicitly provide |
|
I literally just wrote puppetlabs/puppetlabs-apt#1018, but I see yours is more complete. I'll update this one. |
|
It looks like #1473 now breaks EL7 :( |
Passenger is only supported on these, which means Archlinux tests fail.
While this repository no longer relies on it, puppetlabs-apt does. This ensures it's installed.
| if $facts['os']['name'] == 'Ubuntu' { | ||
| # Facter < 4 needs lsb-release for os.distro.codename | ||
| if versioncmp($facts['facterversion'], '4.0.0') <= 0 { | ||
| package { 'lsb-release': | ||
| ensure => installed, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm not a fan of adding this to every single module that needs it.
At least if we do we should probably add it to a file that can be easily removed with modulesync?
There was a problem hiding this comment.
If it's common, perhaps it's something that should live in voxpupuli-acceptance? Right now I don't have time to work on that, but can review things if needed.
This doesn't take care of EL7, which I haven't looked into yet. But it's progress.