-
-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add server/location_acl argument #1491
base: master
Are you sure you want to change the base?
Conversation
use include directive to include server/location ACL file from nginx_conf_dir/conf.d/ dir to not repeat allow/deny lists for every location server/location block
nginx::resource::location is a typethat may have no external impact to Forge modules. nginx::resource::server is a typethat may have no external impact to Forge modules. This module is declared in 9 of 578 indexed public
|
ping |
1 similar comment
ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Please add some units tests for this change
@@ -269,6 +271,7 @@ | |||
Optional[Enum['any', 'all']] $location_satisfy = undef, | |||
Optional[Array] $location_allow = undef, | |||
Optional[Array] $location_deny = undef, | |||
Optional[String] $location_acl = undef, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose the name can't be an empty string
Optional[String] $location_acl = undef, | |
Optional[String[1]] $location_acl = undef, |
Also maybe the user must be able to overwrite the default path nginx::conf_dir/conf.d
?
@@ -290,8 +294,10 @@ | |||
Variant[Array[Stdlib::Absolutepath], Stdlib::Absolutepath] $listen_unix_socket = '/var/run/nginx.sock', | |||
Optional[String] $listen_unix_socket_options = undef, | |||
Optional[Enum['any', 'all']] $location_satisfy = undef, | |||
Optional[String] $server_acl = undef, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here:
Optional[String] $server_acl = undef, | |
Optional[String[1]] $server_acl = undef, |
Pull Request (PR) description
conf.d/name.acl
ACLs to server/location blocks to not repeatallow/deny
rules multiple times.acl
file) withallow/deny
rules in specific block (deny
rule will be the last)