Drop Ubuntu 10/12/14 code #1385
Conversation
| @@ -130,14 +130,6 @@ | |||
| 'log_mode' => '0755', | |||
| 'run_dir' => '/run/nginx', | |||
| } | |||
| } else { | |||
There was a problem hiding this comment.
Why drop this? Doesn't Ubuntu 18.04 hit this? I also think it'd be a better and safer thing to have an else clause. If anything, Xenial should perhaps not manage the repo at all.
There was a problem hiding this comment.
the syntax isn't perfect here, above this block is one explicitly for Debian 9/10 and Ubuntu 18
There was a problem hiding this comment.
Still, having a safe default feels better to me. I'd also be in favor of dropping manage_repo => true and moving to not managing it by default. Then we can make the else block the future proof one so Debian 11/Ubuntu 20.04 are more likely to just work.
There was a problem hiding this comment.
I'm not sure if we should change any default here. However I'm fine with providing a default block that catches newer ubuntu/debian version to be future-proof. My personal preference is also to always use the upstream repositories and not the packages from Ubuntu.
nginx::params is a classBreaking changes to this file MAY impact these 1 modules (near match):This module is declared in 11 of 578 indexed public
|
Can we open an issue for this and let this PR close it? Then it's documented. |
|
closes #1441 |
Pull Request (PR) description
This Pull Request (PR) fixes the following issues