Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protection of private classes is wrong #333

Closed
lbetz opened this issue Jul 4, 2017 · 0 comments · Fixed by #336
Closed

protection of private classes is wrong #333

lbetz opened this issue Jul 4, 2017 · 0 comments · Fixed by #336
Assignees
@lbetz
Labels
bug
Milestone
v1.3.1

Comments

@lbetz
Copy link
Contributor

lbetz commented Jul 4, 2017

if defined($caller_module_name) and $module_name != $caller_module_name and $caller_module_name != '' {
fail("icinga2::feature is a private define resource of the module icinga2, you're not permitted to use it.")
}

should be

if !defined(...) or $module_name != ...

to prevent a call from outside any class and from other modules.
@lbetz lbetz added the bug label Jul 4, 2017
@lbetz lbetz self-assigned this Jul 10, 2017
@lbetz lbetz added this to the v1.3.1 milestone Jul 10, 2017
lbetz added a commit that referenced this issue Jul 10, 2017
@lbetz
fix #333 protection of private classes is wrong
48fd23e
@lbetz lbetz mentioned this issue Jul 10, 2017
Merged
@lbetz lbetz closed this as completed in #336 Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbetz lbetz

Labels
bug
Projects
None yet
Milestone
v1.3.1
Development

Successfully merging a pull request may close this issue.

Update protection of private classes from direct use voxpupuli/puppet-icinga2
1 participant
@lbetz