Skip to content

Commit

Permalink
remove title sort from query_objects
Browse files Browse the repository at this point in the history
  • Loading branch information
@lbetz
lbetz committed Sep 1, 2023
1 parent e3fe541 commit 6610356
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion manifests/query_objects.pp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
} # default
}

$pql_query = puppetdb_query("resources[parameters] { ${_environments} type = 'Icinga2::Config::Fragment' and exported = true and tag = 'icinga2::instance::${destination}' and nodes { deactivated is null and expired is null } order by certname, title }")
$pql_query = puppetdb_query("resources[parameters] { ${_environments} type = 'Icinga2::Config::Fragment' and exported = true and tag = 'icinga2::instance::${destination}' and nodes { deactivated is null and expired is null } order by certname }")

$file_list = $pql_query.map |$object| {
$object['parameters']['target']
Expand Down

3 comments on commit 6610356

@sircubbi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any good reason for this, as it makes the resource-order undeterministic again?

(see #725)

@lbetz
Copy link
Contributor Author

@lbetz lbetz commented on 6610356 Sep 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason was to reduce expenses for sorting. But I forgot the higher probability of a change in the order. Ok, will be back again in a few minutes.

@sircubbi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also thanks for this.

Please sign in to comment.