chore(all): upgrade graceful-fs
#1717
Merged
+26
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eventualbuddha
requested review from
carolinemodic
and removed request for
a team
|
Huh. Nice one tracking this down! |
taravancil
approved these changes
Apr 20, 2022
Ensures that the version of `graceful-fs` in use includes this fix: isaacs/node-graceful-fs#220. This was breaking `jest-resolve` for reasons I don't fully understand, making it unable to load tests for `res-to-ts`. I wasn't able to figure out how to make `pnpm` update `graceful-fs` to the version I wanted as a transitive dependency. I tried `pnpm update graceful-fs@4.2.10` and similar, but none worked. Instead, I manually updated the lockfile to point to `graceful-fs: 4.2.10` and removed the `graceful-fs` entries, then ran `pnpm install` to make `pnpm` fix the broken lockfile. Fixes #1716
eventualbuddha
added a commit
that referenced
this pull request
Apr 21, 2022
Turns out 4.2.4 was sneaking back in after #1717 because of the override in `pnpmfile.js`. This updates the override to use 4.2.10.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #1716
Ensures that the version of
graceful-fsin use includes this fix: isaacs/node-graceful-fs#220. This was breakingjest-resolvefor reasons I don't fully understand, making it unable to load tests forres-to-ts.I wasn't able to figure out how to make
pnpmupdategraceful-fsto the version I wanted as a transitive dependency. I triedpnpm update graceful-fs@4.2.10and similar, but none worked. Instead, I manually updated the lockfile to point tograceful-fs: 4.2.10and removed thegraceful-fsentries, then ranpnpm installto makepnpmfix the broken lockfile.Demo Video or Screenshot
n/a
Testing Plan
Tried using with
node16.14.2, which worked.Checklist