Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed restriction that allowed to exclude only models from a diagram #279

Merged
merged 3 commits into from
May 10, 2019
Merged

Removed restriction that allowed to exclude only models from a diagram #279

merged 3 commits into from
May 10, 2019

Conversation

bpohoriletz
Copy link

@bpohoriletz bpohoriletz commented Sep 21, 2017

Especially helpful when having polymorphic/indirect relationships

@kerrizor
Copy link
Collaborator

Hi! Thanks for submitting this, and thank you for your patience.. this looks good, but now I'm nervous that we don't have a test for this (but then, this blob of code has been a near constant source of pain for me..) How confident can we be that we're not removing functionality here?

@kerrizor kerrizor added this to the v1.6.0 milestone Jan 10, 2018
@bpohoriletz
Copy link
Author

@kerrizor when do you plan to release v1.6.0? I'd be happy to add tests for this.

@kerrizor
Copy link
Collaborator

@bpohoriletz It'll be a few weeks at least, so plenty of time if its something you'd like to add!

@bpohoriletz
Copy link
Author

Hello,
I've added a test for the new exclusion rule, I can't run test for rake tasks in my local.
I'm quite sure that it does not remove any functionality for two reasons:

  1. Building a graph will work fine after the change. The code draw_node entity.name, entity_options(entity, attributes) requires only name and all entities have it
  2. Before the change one could not remove entities that were not models from the graph, so the change makes exclusion more restrictive if needed

Thanks!

@kerrizor
Copy link
Collaborator

Hi, and thanks for the PR! Apologies on not responding sooner; my workflow for being notified of new issues broke such that I received some notifications, but not all, and unfortunately yours was one I missed.

If you have the time, could you rebase and resubmit? I recently merged fixes for minitest that may help clear up your test failures.

@bpohoriletz
Copy link
Author

@kerrizor no problem at all, thank you for all your work!

@kerrizor kerrizor merged commit cb5686e into voormedia:master May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants