Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview extension: switch to LabIcon for the refresh button #884

Merged
merged 2 commits into from
May 28, 2021
Merged

Preview extension: switch to LabIcon for the refresh button #884

merged 2 commits into from
May 28, 2021

Conversation

ohrely
Copy link
Contributor

@ohrely ohrely commented May 7, 2021 •
edited
Loading

Addresses #620

Collaboration with @VickyPrakash

@ohrely ohrely marked this pull request as ready for review May 7, 2021 17:37
@ohrely @ivanov
fix typo in packages/jupyterlab-preview/src/preview.tsx
e3442c8 
Co-authored-by: Paul Ivanov <pi@berkeley.edu>
jtpio
jtpio approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 0fe1cb8 into voila-dashboards:master May 28, 2021
@jtpio jtpio added the jupyterlab-preview JupyterLab Preview Extension label May 28, 2021
@ohrely ohrely deleted the previewicon branch May 28, 2021 22:00
@jtpio jtpio added the enhancement New feature or request label Jun 23, 2021
@jtpio jtpio mentioned this pull request Sep 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanov ivanov ivanov requested changes

@jtpio jtpio jtpio approved these changes

@SylvainCorlay SylvainCorlay SylvainCorlay approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request jupyterlab-preview JupyterLab Preview Extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ohrely @ivanov @jtpio @SylvainCorlay