Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix Voilà endpoint in Binder config #801

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

thomas-bc
Copy link
Contributor

Fixes #776

As presented in #776, the Voilà endpoint (when using Voilà in Binder) can fail with a leading slash.
I simply propose to make the no-leading-slash version the proposed one in the official documentation.

It isn't much, but I spent a couple minutes figuring it out.. so I hope this will save some time to other people in the future.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 7bda9d1 into voila-dashboards:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation] Configuration field for running Voila with Binder is misleading
2 participants