Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation steps in the doc tests section #700

Merged
merged 2 commits into from
Sep 16, 2020

Conversation

martinRenou
Copy link
Member

No description provided.

Signed-off-by: martinRenou <martin.renou@gmail.com>
@@ -143,13 +143,13 @@ Install the test dependencies

.. code-block:: bash

python -m pip install -e ".[test]"
python -m pip install ".[test]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can leave the -e if we enable the extension right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe? I was not able to run any test on my side. I did not find a combination that works.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run (cd tests/test_template; pip install .) ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

@SylvainCorlay SylvainCorlay merged commit 781ce68 into voila-dashboards:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants