fix: use template_paths instead of old template_path #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In jupyter/nbconvert#1310 we got rid of template_path, and set the template_paths. This also means we don't have to override the get_template_paths since template_paths is a trait, where the old get_template_paths is the default (method).
maartenbreddels
force-pushed
the
fix_template_path_to_paths
branch
from
e446987
to
7d8ddf7
Compare
|
Strange failure, also see it in master |
|
Fixed after rerunning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In jupyter/nbconvert#1310 we got rid of template_path, and set the template_paths. This also means we don't have to override the get_template_paths since template_paths is a trait, where the old get_template_paths is the default (method).