Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt before open_voila. #632

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cailiang9
Copy link
Contributor

Prompt before open_voila to avoid accidentally trigger voila button.
Because some temporary cells would contain commands such as "!rm file.csv", thus executing all cells would cause data loss.

Prompt before open_voila to avoid accidentally trigger voila button.
Because some temporary cells would contain commands such as "!rm file.csv", thus executing all cells would cause data loss.
@cailiang9
Copy link
Contributor Author

looks like the check failure is irrelevant to the modification of voila/static/extension.js .

@jtpio
Copy link
Member

jtpio commented Jul 9, 2020

Thanks @cailiang9.

It would be nice to still stay one click away from the voila dashboard for the users who don't want the modal.

Maybe the modal should show a "Do not ask again" checkbox? Or be made configurable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants