Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow voila to run a server extension for notebook <5 #390

Merged
merged 1 commit into from
Oct 3, 2019
Merged

fix: allow voila to run a server extension for notebook <5 #390

merged 1 commit into from
Oct 3, 2019

Conversation

maartenbreddels
Copy link
Member

No description provided.

@aschlaep
Copy link
Member

aschlaep commented Oct 2, 2019

I was able to get this working with our version of notebook

@jtpio
Copy link
Member

jtpio commented Oct 3, 2019

Looks good, thanks @maartenbreddels!

@jtpio jtpio merged commit cd80389 into voila-dashboards:master Oct 3, 2019
@jtpio
Copy link
Member

jtpio commented Oct 3, 2019

And thanks @aschlaep for trying it out.

@maartenbreddels maartenbreddels deleted the fix_notebook_pre_5 branch October 7, 2019 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maartenbreddels @aschlaep @jtpio