Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JLab extension: minor fixes #256

Merged
merged 3 commits into from
Jun 19, 2019
Merged

JLab extension: minor fixes #256

merged 3 commits into from
Jun 19, 2019

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jun 18, 2019 •
edited
Loading

Changes

  • Add yarn.lock
  • Update author to Voila contributors
  • Remove peerDependencies

@jtpio jtpio changed the title Add yarn.lock, update author JLab extension: minor fixes Jun 18, 2019
@jtpio
Copy link
Member Author

jtpio commented Jun 18, 2019

@SylvainCorlay @maartenbreddels fine for changing the author to "Voila contributors"? (same as for the license)

@maartenbreddels
Copy link
Member

maartenbreddels commented Jun 18, 2019 via email

@SylvainCorlay
Copy link
Member

Absolutely

@jtpio
Copy link
Member Author

jtpio commented Jun 19, 2019

Good 👍

@jtpio jtpio merged commit c2806f2 into voila-dashboards:master Jun 19, 2019
@jtpio jtpio deleted the jlab-yarn branch June 19, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtpio @maartenbreddels @SylvainCorlay