Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch browser after listening #243

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jun 14, 2019

Launch the web browser only after the server is running (started to listen).

This prevents from opening a new tab when there is already an instance of voila running and another one is started afterwards using the same port (default for example).

@maartenbreddels
Copy link
Member

Thanks, indeed annoying behaviour!

@maartenbreddels maartenbreddels merged commit 859376d into voila-dashboards:master Jun 14, 2019
@jtpio jtpio deleted the open-browser-listen branch June 14, 2019 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants